usb-tools/amaranth
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

lib.wiring: remove unnecessary flipping in Signature.flatten.

Browse source
This commit is contained in:
Catherine 2024-03-15 10:29:12 +00:00
parent 3e6e78012d
commit 11ec35d258
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
amaranth/lib/wiring.py
View file

@ -798,8 +798,6 @@ class Signature(metaclass=SignatureMeta):
yield path, Member(member.flow, member.shape, init=member.init), value yield path, Member(member.flow, member.shape, init=member.init), value
elif member.is_signature: elif member.is_signature:
for sub_path, sub_member, sub_value in member.signature.flatten(value): for sub_path, sub_member, sub_value in member.signature.flatten(value):
if member.flow == In:
sub_member = sub_member.flip()
yield ((*path, *sub_path), sub_member, sub_value) yield ((*path, *sub_path), sub_member, sub_value)
else: else:
assert False # :nocov: assert False # :nocov:

4
tests/test_lib_wiring.py
View file

@ -373,8 +373,8 @@ class SignatureTestCase(unittest.TestCase):
self.assertFlattenedSignature(sig.flatten(intf), [ self.assertFlattenedSignature(sig.flatten(intf), [
(("a", "p"), Out(1), intf.a.p), (("a", "p"), Out(1), intf.a.p),
(("b", "q"), In (1), intf.b.q), (("b", "q"), In (1), intf.b.q),
(("c", "r"), Out(1), intf.c.r), (("c", "r"), In (1), intf.c.r),
(("d", "s"), In (1), intf.d.s), (("d", "s"), Out(1), intf.d.s),
]) ])
def test_is_compliant_signature(self): def test_is_compliant_signature(self):