usb-tools/amaranth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

lib.data: warn if a field is shadowed by an attribute of the view.

Browse source 
Fixes #796.
This commit is contained in:
Catherine 2023-05-31 12:22:04 +00:00
parent f96604f667
commit 2a45d0e9ad
2 changed files with 23 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

16
tests/test_lib_data.py
View file

@ -465,6 +465,22 @@ class ViewTestCase(FHDLTestCase):
r"^View layout must be a layout, not <.+?>$"):
View(object(), Signal(1))
def test_layout_conflict_with_attr(self):
with self.assertWarnsRegex(SyntaxWarning,
r"^View layout includes a field 'as_value' that will be shadowed by the view "
r"attribute 'amaranth\.lib\.data\.View\.as_value'$"):
View(StructLayout({"as_value": unsigned(1)}), Signal(1))
def test_layout_conflict_with_attr_derived(self):
class DerivedView(View):
def foo(self):
pass
with self.assertWarnsRegex(SyntaxWarning,
r"^View layout includes a field 'foo' that will be shadowed by the view "
r"attribute 'tests\.test_lib_data\.ViewTestCase\."
r"test_layout_conflict_with_attr_derived\.<locals>.DerivedView\.foo'$"):
DerivedView(StructLayout({"foo": unsigned(1)}), Signal(1))
def test_target_wrong_type(self):
with self.assertRaisesRegex(TypeError,
r"^View target must be a value-castable object, not <.+?>$"):