usb-tools/amaranth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

lib.wiring: allow reset-less signals in interfaces.

Browse source 
This check was originally added out of abundance of caution, but since
then it was observed that reset-less-ness is purely an implementation
detail (see #1220), and furthermore it interferes with adaptation of
`FIFOInterface`` signals (where `[rw]_data` are reset-less) for RFC 61.
This commit is contained in:
Catherine 2024-04-03 11:50:11 +00:00
parent 606ebcd7a9
commit 3c6f46717b
3 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
amaranth/lib/wiring.py
View file

@ -893,10 +893,6 @@ class Signature(metaclass=SignatureMeta):
f"the initial value {member.init!r}, but it has "
f"the initial value {attr_value_cast.init!r}")
return False
if attr_value_cast.reset_less:
if reasons is not None:
reasons.append(f"{_format_path(path)} is expected to not be reset-less")
return False
return True
if member.is_signature:
return member.signature.is_compliant(attr_value, reasons=reasons, path=path)