usb-tools/amaranth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

hdl.ast: warn on bare integer value used in Cat()/Repl().

Browse source 
Fixes #639.
This commit is contained in:
whitequark 2021-12-11 08:18:33 +00:00
parent de7c9acb19
commit 44b8bd29af
2 changed files with 36 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

23
tests/test_hdl_ast.py
View file

@ -746,6 +746,17 @@ class CatTestCase(FHDLTestCase):
r"^Object 'foo' cannot be converted to an Amaranth value$"):
Cat("foo")
def test_int_01(self):
with warnings.catch_warnings():
warnings.filterwarnings(action="error", category=SyntaxWarning)
Cat(0, 1, 1, 0)
def test_int_wrong(self):
with self.assertWarnsRegex(SyntaxWarning,
r"^Argument #1 of Cat\(\) is a bare integer 2 used in bit vector context; "
r"consider specifying explicit width using C\(2, 2\) instead$"):
Cat(2)
class ReplTestCase(FHDLTestCase):
def test_shape(self):
@ -769,6 +780,18 @@ class ReplTestCase(FHDLTestCase):
r = Repl(0, 3)
self.assertEqual(repr(r), "(repl (const 1'd0) 3)")
def test_int_01(self):
with warnings.catch_warnings():
warnings.filterwarnings(action="error", category=SyntaxWarning)
Repl(0, 3)
Repl(1, 3)
def test_int_wrong(self):
with self.assertWarnsRegex(SyntaxWarning,
r"^Value argument of Repl\(\) is a bare integer 2 used in bit vector context; "
r"consider specifying explicit width using C\(2, 2\) instead$"):
Repl(2, 3)
class ArrayTestCase(FHDLTestCase):
def test_acts_like_array(self):