usb-tools/amaranth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

lib.wiring: fix equality of FlippedSignature with other object.

Browse source 
Fixes #882.
This commit is contained in:
Catherine 2023-08-31 18:59:12 +00:00
parent cfd4f9c84e
commit 44d5fac01c
2 changed files with 17 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
amaranth/lib/wiring.py
View file

@ -484,9 +484,11 @@ class FlippedSignature:
return self.flip() == other.flip()
else:
# Delegate comparisons back to Signature (or its descendant) by flipping the arguments;
# equality must be reflexive but the implementation of __eq__ need not be, and we can
# take advantage of it here.
return other == self
# equality must be reflexive but the implementation of `__eq__` need not be, and we can
# take advantage of it here. This is done by returning `NotImplemented`, otherwise if
# the other object cannot be compared to a `FlippedSignature` either this will result
# in infinite recursion.
return NotImplemented
# These methods do not access instance variables and so their implementation can be shared
# between the normal and the flipped member collections.