usb-tools/amaranth
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Explicitly restrict prelude imports.

Browse source 
It turns out that while Python does not import _private identifiers
when using * imports, it does nevertheless import all submodules.

Avoid polluting the namespace in the prelude by explicitly listing
all exported identifiers.
This commit is contained in:
whitequark 2019-10-21 10:39:21 +00:00
parent 9fba5ccb51
commit 61e6267daf
2 changed files with 28 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
nmigen/__init__.py
View file

@ -4,4 +4,18 @@ try:
except pkg_resources.DistributionNotFound: except pkg_resources.DistributionNotFound:
pass pass
from .hdl import * from .hdl import *
__all__ = [
"Shape", "unsigned", "signed",
"Value", "Const", "C", "Mux", "Cat", "Repl", "Array", "Signal", "ClockSignal", "ResetSignal",
"Module",
"ClockDomain",
"Elaboratable", "Fragment", "Instance",
"Memory",
"Record",
"DomainRenamer", "ResetInserter", "EnableInserter",
"CEInserter", # TODO(nmigen-0.2): remove this
]

15
nmigen/hdl/__init__.py
View file

@ -6,4 +6,17 @@ from .ir import Elaboratable, Fragment, Instance
from .mem import Memory from .mem import Memory
from .rec import Record from .rec import Record
from .xfrm import DomainRenamer, ResetInserter, EnableInserter, \ from .xfrm import DomainRenamer, ResetInserter, EnableInserter, \
CEInserter # deprecated CEInserter # TODO(nmigen-0.2): remove this
__all__ = [
"Shape", "unsigned", "signed",
"Value", "Const", "C", "Mux", "Cat", "Repl", "Array", "Signal", "ClockSignal", "ResetSignal",
"Module",
"ClockDomain",
"Elaboratable", "Fragment", "Instance",
"Memory",
"Record",
"DomainRenamer", "ResetInserter", "EnableInserter",
"CEInserter", # TODO(nmigen-0.2): remove this
]