usb-tools/amaranth
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

hdl.ast: make Signal(name=) a keyword-only argument.

Browse source 
Almost no code would specify Signal(_, name) as a positional argument
on purpose, but forgetting parens and accidentally placing signedness
into the name position is so common that we had a test for it.
This commit is contained in:
whitequark 2019-09-23 11:08:43 +00:00
parent 2da0133d52
commit 649444449d
2 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
nmigen/hdl/ast.py
View file

@ -729,7 +729,7 @@ class Signal(Value, DUID):
attrs : dict attrs : dict
""" """
def __init__(self, shape=None, name=None, *, reset=0, reset_less=False, min=None, max=None, def __init__(self, shape=None, *, name=None, reset=0, reset_less=False, min=None, max=None,
attrs=None, decoder=None, src_loc_at=0): attrs=None, decoder=None, src_loc_at=0):
super().__init__(src_loc_at=src_loc_at) super().__init__(src_loc_at=src_loc_at)

6
nmigen/test/test_hdl_ast.py
View file

@ -582,12 +582,6 @@ class SignalTestCase(FHDLTestCase):
s2 = Signal(name="sig") s2 = Signal(name="sig")
self.assertEqual(s2.name, "sig") self.assertEqual(s2.name, "sig")
def test_name_bad(self):
with self.assertRaises(TypeError,
msg="Name must be a string, not 'True'"):
# A common typo: forgetting to put parens around width and signedness
Signal(1, True)
def test_reset(self): def test_reset(self):
s1 = Signal(4, reset=0b111, reset_less=True) s1 = Signal(4, reset=0b111, reset_less=True)
self.assertEqual(s1.reset, 0b111) self.assertEqual(s1.reset, 0b111)