usb-tools/amaranth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

hdl.dsl: add missing case width check for Enum values.

Browse source 
Fixes #305.
This commit is contained in:
whitequark 2020-01-31 23:14:16 +00:00
parent a9da9efe5b
commit 687d3a3df7
2 changed files with 14 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
nmigen/hdl/dsl.py
View file

@ -309,6 +309,13 @@ class Module(_ModuleBuilderRoot, Elaboratable):
.format(pattern, len(switch_data["test"])),
SyntaxWarning, stacklevel=3)
continue
if isinstance(pattern, Enum) and bits_for(pattern.value) > len(switch_data["test"]):
warnings.warn("Case pattern '{:b}' ({}.{}) is wider than switch value "
"(which has width {}); comparison will never be true"
.format(pattern.value, pattern.__class__.__name__, pattern.name,
len(switch_data["test"])),
SyntaxWarning, stacklevel=3)
continue
new_patterns = (*new_patterns, pattern)
try:
_outer_case, self._statements = self._statements, []