usb-tools/amaranth
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

lib.wiring: use is for type comparison in Component.

Browse source 
This avoids running custom `__eq__` implementations, which could
cause issues such as #882.
This commit is contained in:
Catherine 2023-08-31 19:19:38 +00:00
parent 44d5fac01c
commit 88cbf30128
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
amaranth/lib/wiring.py
View file

@ -760,7 +760,7 @@ class Component(Elaboratable):
for name, annot in getattr(base, "__annotations__", {}).items(): for name, annot in getattr(base, "__annotations__", {}).items():
if name.startswith("_"): if name.startswith("_"):
continue continue
if (annot in (Value, Signal, Const) or if (annot is Value or annot is Signal or annot is Const or
(isinstance(annot, type) and issubclass(annot, ValueCastable)) or (isinstance(annot, type) and issubclass(annot, ValueCastable)) or
isinstance(annot, Signature)): isinstance(annot, Signature)):
if isinstance(annot, type): if isinstance(annot, type):