usb-tools/amaranth
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

back.rtlil: avoid exponential behavior when legalizing Part().

Browse source 
Fixes #259.
This commit is contained in:
whitequark 2019-10-26 02:01:53 +00:00
parent ffd10e3042
commit 8b05b28f5a
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
nmigen/back/rtlil.py
View file

@ -622,12 +622,19 @@ class _LHSValueCompiler(_ValueCompiler):
def on_Part(self, value): def on_Part(self, value):
offset = self.s.expand(value.offset) offset = self.s.expand(value.offset)
if isinstance(offset, ast.Const): if isinstance(offset, ast.Const):
if offset.value == len(value.value):
dummy_wire = self.s.rtlil.wire(value.width)
return dummy_wire
return self(ast.Slice(value.value, return self(ast.Slice(value.value,
offset.value * value.stride, offset.value * value.stride,
offset.value * value.stride + value.width)) offset.value * value.stride + value.width))
else: else:
# Only so many possible parts. The amount of branches is exponential; if value.offset
# is large (e.g. 32-bit wide), trying to naively legalize it is likely to exhaust
# system resources.
max_branches = len(value.value) // value.stride + 1
raise LegalizeValue(value.offset, raise LegalizeValue(value.offset,
range((1 << len(value.offset)) // value.stride), range((1 << len(value.offset)) // value.stride)[:max_branches],
value.src_loc) value.src_loc)
def on_Repl(self, value): def on_Repl(self, value):