usb-tools/amaranth
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

build.run: Ensure batch script returns proper error code.

Browse source
This commit is contained in:
William D. Jones 2019-07-14 13:28:19 -04:00 committed by whitequark
parent ee15538cf0
commit b963449b41
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
nmigen/build/run.py
View file

@ -71,7 +71,13 @@ class BuildPlan:
if run_script:
if sys.platform.startswith("win32"):
subprocess.check_call(["cmd", "/c", "{}.bat".format(self.script)])
# Without "call", "cmd /c {}.bat" will return 0.
# See https://stackoverflow.com/a/30736987 for a detailed
# explanation of why, including disassembly/decompilation
# of relevant code in cmd.exe.
# Running the script manually from a command prompt is
# unaffected- i.e. "call" is not required.
subprocess.check_call(["cmd", "/c", "call {}.bat".format(self.script)])
else:
subprocess.check_call(["sh", "{}.sh".format(self.script)])