usb-tools/amaranth
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

build.plat: avoid type confusion in _check_feature.

Browse source 
Before this commit, `_check_feature(valid_xdrs=0)` would mean that
XDR buffers are not supported. Only `_check_feature(valid_xdrs=())`
was intended to be an indicator of that.
This commit is contained in:
whitequark 2020-10-15 08:54:48 +00:00
parent 69ed4918b8
commit d22b2c5604
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
nmigen/build/plat.py
View file

@ -177,7 +177,7 @@ class Platform(ResourceManager, metaclass=ABCMeta):
.format(type(self).__name__)) .format(type(self).__name__))
def _check_feature(self, feature, pin, attrs, valid_xdrs, valid_attrs): def _check_feature(self, feature, pin, attrs, valid_xdrs, valid_attrs):
if not valid_xdrs: if len(valid_xdrs) == 0:
raise NotImplementedError("Platform '{}' does not support {}" raise NotImplementedError("Platform '{}' does not support {}"
.format(type(self).__name__, feature)) .format(type(self).__name__, feature))
elif pin.xdr not in valid_xdrs: elif pin.xdr not in valid_xdrs: