usb-tools/amaranth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

lib.data: make all layouts immutable.

Browse source 
This is actually an existing correctness requirement (for the similar
reasons that ValueCastable.as_value() must always return the same
value every time) that for some reason wasn't respected.
This commit is contained in:
Catherine 2023-05-23 22:14:16 +00:00
parent 52b9d3f799
commit f96604f667
2 changed files with 37 additions and 67 deletions
Download patch file Download diff file Expand all files Collapse all files

11
tests/test_lib_data.py
View file

@ -263,6 +263,11 @@ class FlexibleLayoutTestCase(TestCase):
self.assertEqual(il["b"], Field(unsigned(3), 0))
self.assertEqual(il[0], Field(unsigned(2), 5))
def test_is_not_mutated(self):
il = FlexibleLayout(8, {"a": Field(unsigned(1), 0)})
del il.fields["a"]
self.assertIn("a", il.fields)
def test_eq(self):
self.assertEqual(FlexibleLayout(3, {"a": Field(unsigned(1), 0)}),
FlexibleLayout(3, {"a": Field(unsigned(1), 0)}))
@ -325,12 +330,6 @@ class FlexibleLayoutTestCase(TestCase):
r"^Flexible layout field 'a' ends at bit 5, exceeding the size of 4 bit\(s\)$"):
FlexibleLayout(4, {"a": Field(unsigned(2), 3)})
def test_size_wrong_shrink(self):
il = FlexibleLayout(8, {"a": Field(unsigned(2), 3)})
with self.assertRaisesRegex(ValueError,
r"^Flexible layout size 4 does not cover the field 'a', which ends at bit 5$"):
il.size = 4
def test_key_wrong_missing(self):
il = FlexibleLayout(8, {"a": Field(unsigned(2), 3)})
with self.assertRaisesRegex(KeyError,