usb-tools/amaranth
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

lib.memory: remove Memory.Init.depth.

Browse source 
This attribute is fully redundant with `.__len__()`, and is out of place
on a `list`-like container like `Memory.Init`.

The `.shape` attribute, however, provides a unique function.
This commit is contained in:
Catherine 2024-03-22 21:15:17 +00:00
parent 2640033316
commit fc84b8decf
2 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
amaranth/lib/memory.py
View file

@ -88,11 +88,6 @@ class Memory(wiring.Component):
def shape(self):
return self._shape
# TODO: redundant with __len__
@property
def depth(self):
return self._depth
def __getitem__(self, index):
return self._elems[index]

2
tests/test_lib_memory.py
View file

@ -285,7 +285,7 @@ class MemoryTestCase(FHDLTestCase):
self.assertEqual(m.shape, 8)
self.assertEqual(m.depth, 4)
self.assertEqual(m.init.shape, 8)
self.assertEqual(m.init.depth, 4)
self.assertEqual(len(m.init), 4)
self.assertEqual(m.attrs, {})
self.assertIsInstance(m.init, memory.Memory.Init)
self.assertEqual(list(m.init), [1, 2, 3, 0])